Delete Button

12-03-2010, 07:48 PM

DarylN

Newcomer

Join Date: Dec 2010

Posts: 1

Delete Button

Hey guys:

I am trying to code a delete button for a browsing program based on data from a txt file. I have coded the buttons to sort(ascending and descending), append to the text file, search the text file, but I can not seem to get the delete function working. I am using VB 2010, this is what I have so far:

Code:

Dim deleline As String
        Dim line As String
        Dim isFound As Boolean = False
        sr4 = IO.File.OpenText("Students.txt")
        sw = IO.File.CreateText("Testing.txt")
        sw = IO.File.CreateText("Temp.txt")
        deleline = sr4.ReadLine()
        Dim fn, ln, major, phone, mail, gpa As String
        fn = txtFirstName.Text.Substring(0, 1).ToUpper & txtFirstName.Text.Substring(1)
        ln = txtLastName.Text.Substring(0, 1).ToUpper & txtLastName.Text.Substring(1)
        major = txtMajor.Text.Substring(0, 1).ToUpper & txtMajor.Text.Substring(1)
        phone = txtPhone.Text
        mail = txtMail.Text
        gpa = txtGpa.Text
        line = fn & " " & ln & " " & major & " " & phone & " " & mail & " " & gpa
        For i = 0 To sr4.Peek - 1
            If isFound = False Then
                If deleline = line Then
                    sw.WriteLine(n)
                ElseIf isFound = True Then
                    n += 1
                End If
            End If
            n += 1
        Next
        sr4.Close()

        sw.Close()

        IO.File.Delete("Students.txt")
        IO.File.Move("Testing.txt", "Students.txt")
    End Sub

any help or tips will be appreciated thanks

Last edited by passel; 12-05-2010 at 03:22 PM. Reason: Added code tags

12-04-2010, 11:15 AM

snarfblam

Senior Contributor

Forum Leader
* Expert *

Join Date: Apr 2005

Location: USA

Posts: 896

Quote:

Originally Posted by DarylN

I can not seem to get the delete function working.

You aren't explaining the problem. Is there an error? Also, it would help if you used [Code] tags for readability and maybe comment the code or remove bits irrelevant to the question.

__________________
C# _VB.NET _

12-05-2010, 04:08 PM

passel

Sinecure Expert

Super Moderator
* Guru *

Join Date: Jun 2003

Location: Upstate New York, usa

Posts: 8,031

I'm not sure what you're doing.
To delete a line from a file I would expect somthing along the lines of

Code:

Open the file for input
Open a temp file for output
Do until no lines left in the file
  Read a line from the file
  If the line is not the one we want deleted then
    write the line to the temp file
  End if
Loop
Close the files
Copy the temp file to the file.

Now, the code you have currently, looks like it is trying to debug your logic, not do the task.
The code looks like it would wipe out your input file, since you open a second file using sw "Temp.txt" and write to that, and then copy "Testing.txt" to your input file which wasn't written to.

In any case, there seems to be a number of obvious flaws in the code logic, regardless of what you intended.

You have a condition, If isFound = False, then inside that condition you test for isFound = True. isFound can never be True since it had to be False to get to that code.

Your loop, For i = 0 to sr4.Peek-1, might work, I haven't tried it, but I wouldn't do that.
Peek is a function which should return the byte offset of the next character to be read from the file. You're not reading new lines from the file in your loop, so the Peek function should never return a different number, so will loop some arbitrary number of times (the length of the first line read from the file + 1), but even if you were reading lines in the loop, I would be surprised if it didn't end up not reading the whole file, or reading past the end of the file.

__________________
There Is An Island Of Opportunity In The Middle of Every Difficulty.
Miss That, Though, And You're Pretty Much Doomed.