rasheemo

I made it so that if the square runs into the small circle, the circle disappears, but somehow when i execute it it takes a few tries of pressing left and right to get the circle to go away. The timers are obviously used to make the swuare move at a constant rate.


Private Sub Form_KeyDown(KeyCode As Integer, Shift As Integer)
Dim intP1Counter As Integer
Dim intP2Counter As Integer

Select Case KeyCode

''''''''''''''''''''''''''''''''''''''''''''''''''''''''' P1 Pacman
Case vbKeyUp
timUp.Enabled = True
timDown.Enabled = False
timLeft.Enabled = False
timRight.Enabled = False

Case vbKeyDown
timDown.Enabled = True
timUp.Enabled = False
timLeft.Enabled = False
timRight.Enabled = False

Case vbKeyRight
timUp.Enabled = False
timDown.Enabled = False
timLeft.Enabled = False
timRight.Enabled = True

Case vbKeyLeft
timUp.Enabled = False
timDown.Enabled = False
timLeft.Enabled = True
timRight.Enabled = False
''''''''''''''''''''''''''''''''''''''''''''''''''''''''' P2 Pacman
Case vbKeyW
timA.Enabled = False
timS.Enabled = False
timW.Enabled = True
timD.Enabled = False

Case vbKeyS
timA.Enabled = False
timS.Enabled = True
timW.Enabled = False
timD.Enabled = False

Case vbKeyD
timA.Enabled = False
timS.Enabled = False
timW.Enabled = False
timD.Enabled = True

Case vbKeyA
timA.Enabled = True
timS.Enabled = False
timW.Enabled = False
timD.Enabled = False
'''''''''''''''''''''''''''''''''''''''''''''''''''''''''

End Select

If shpPacman1.Left < shpTarget.Left + shpTarget.Width And shpTarget.Left < shpPacman1.Left + shpPacman1.Width Then
If shpPacman1.Top < shpTarget.Top + shpTarget.Height And shpTarget.Top < shpPacman1.Top + shpPacman1.Height Then
shpTarget.Visible = False
intP1Counter = intP1Counter + 1
lblScore1.Caption = intP1Counter
End If
End If

If shpPacman2.Left < shpTarget.Left + shpTarget.Width And shpTarget.Left < shpPacman2.Left + shpPacman2.Width Then
If shpPacman2.Top < shpTarget.Top + shpTarget.Height And shpTarget.Top < shpPacman2.Top + shpPacman2.Height Then
shpTarget.Visible = False
intP2Counter = intP2Counter + 1
lblScore2.Caption = intP2Counter
End If
End If

End Sub

jumentous

put the collision detect code into a sub and then call it from the timers because your keydown event isn't actually moving either pacman, all its doing is telling the timers to start moving the pacmans, this code will only be triggered when you actually press the key and so if it runs into the square when moving on its own it wont detect the collision, this is why it works when you click a key again while the pacmans are overlapped.


BTW, you may like to stay how it is but investigate using just 1 timer and having boolean values to see which way it is moving, if for no other reason than the timers wont all trigger at the same time


Edit: And use [vb][/vb] tags

rasheemo

oooOOOoo thanks a lot! i never would have guessed!

What do you mean putting it as a boolean expression? DO you mean i should put the key selects in a timer or something?

rasheemo

nm i got it! thanks